Fix setting --driver with env variables #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
force-pushed
the
fix-driver-binding
branch
from
71ddc2d to
dbf4a02
Compare
|
/azp run porter-integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
carolynvs
force-pushed
the
fix-driver-binding
branch
from
dbf4a02 to
41fd3cf
Compare
|
/azp run porter-integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This binds the --driver flag for porter install|invoke|upgrade|uninstall to the PORTER_RUNTIME_DRIVER environment variable used by the operator. I had already done this for PORTER_BUILD_DRIVER, but missed adding similar configuration bindings for runtime. So in the config file, the user can set rutime-driver and build-driver. The environment variables are named: PORTER_RUNTIME_DRIVER and PORTER_BUILD_DRIVER. The flag though on any command is just --driver for simplicity, e.g. porter install --driver kubernetes. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
force-pushed
the
fix-driver-binding
branch
from
41fd3cf to
824cb73
Compare
vdice
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
This binds the --driver flag for porter install|invoke|upgrade|uninstall
to the PORTER_RUNTIME_DRIVER environment variable used by the operator.
I had already done this for PORTER_BUILD_DRIVER, but missed adding
similar configuration bindings for runtime.
So in the config file, the user can set runtime-driver and build-driver.
The environment variables are named: PORTER_RUNTIME_DRIVER and
PORTER_BUILD_DRIVER. The flag though on any command is just --driver for
simplicity, e.g. porter install --driver kubernetes.
I added docs to the CLI helptext for the affected commands to explain that you can use these environment variables: https://deploy-preview-1848--porter.netlify.app/cli/porter_bundles_install/
What issue does it fix
This is part of getporter/operator#27.
Notes for the reviewer
N/A
Checklist